Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close streams when protocol limits are reached #1301

Merged
merged 3 commits into from
Jul 22, 2022
Merged

fix: close streams when protocol limits are reached #1301

merged 3 commits into from
Jul 22, 2022
+30 −17

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jul 21, 2022 •
edited
Loading

  • If a stream is opened that exceeds inbound/outbound limits, reset that stream (if it is incoming) or abort and throw (if it is outgoing)
  • Make the error message more helpful (say which protocol has breached the limit)
  • Increase the default stream limits so we don't trigger this by accident when a remote dials us with a protocol we don't support

@achingbrain
fix: close streams when protocol limits are reached
f35b850 
- If a stream is opened that exceeds inbound/outbound limits, reset that stream (if it is incoming) or throw (if it is outgoing)
- Make the error message more helpful (say which stream has breached the limit)
- Increase the default stream limits so we don't trigger this by accident when a remote dials us with a protocol we don't support
@achingbrain
chore: update deps
81b9567
@achingbrain
chore: linting
a0ab896
@achingbrain achingbrain requested a review from wemeetagain July 22, 2022 09:56
@achingbrain achingbrain mentioned this pull request Jul 22, 2022
Merged
@wemeetagain wemeetagain mentioned this pull request Jul 22, 2022
Closed
wemeetagain
wemeetagain approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@achingbrain achingbrain merged commit 3c0fb13 into master Jul 22, 2022
@achingbrain achingbrain deleted the fix/close-streams-when-limit-reached branch July 22, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @wemeetagain